Fix Android 12 - FLAG_IMMUTABLE or FLAG_MUTABLE #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin works perfectly in all devices except for Andorid 12.
I get following error
```
Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent
```
I see the problem is in `createPendingIntent` Method
```
private void createPendingIntent() {
if (pendingIntent == null) {
Activity activity = getActivity();
Intent intent = new Intent(activity, activity.getClass());
intent.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP | Intent.FLAG_ACTIVITY_CLEAR_TOP);
pendingIntent = PendingIntent.getActivity(activity, 0, intent, 0); // Problem in the last param here
}
}
```
This PR solves the problem by just adding the requried flag which also works for lower android versions
|
@don hey, by any chance can you look at this PR please? It will be very very helpful. |
|
I confirm this bug happens on Android 12 and hardcrashes any app with thepluging. In the meantime: [...]
"dependencies": {
"phonegap-nfc": "SachinAgarwal1337/phonegap-nfc#patch-1",
[...]
}(Ping @don) |
|
I am also confirming on this bug, and it is blocker for using the plugin in Android 12 + (12 or 13 beta). (Ping @don ) |
|
Hi @don, @krimple, @gonzalo123, @doncoleman - any updates on this? |
|
Hi @don @gonzalo123 @doncoleman - Any update on this? |
|
Any Update??? |
paolosanchi
added a commit
to paolosanchi/phonegap-nfc
that referenced
this pull request
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin works perfectly in all devices except for Andorid 12.
I get following error
I see the problem is in
createPendingIntentMethodThis PR solves the problem by just adding the requried flag which also works for lower android versions
Solve the issue I raised #465