Update NfcPlugin.java #156
Conversation
modified to read Mifare Classic cards example call nfc.readMifare(success,error); nfc.readMifareSecBloc(sector,block,success,error);
| @@ -70,7 +72,13 @@ | |||
|
|
|||
| private CallbackContext shareTagCallback; | |||
| private CallbackContext handoverCallback; | |||
|
|
|||
| private static final String READMIFARE ="readMf"; | |||
| private static final String READMIFARE_SB="readMf_SB"; | |||
There was a problem hiding this comment.
Fix your indentation so it matches please!
|
Yea you got this wrong, yous hould only have one pull erquest with your javascript and your java in.. Read about using git, it's worth understanding... Read this too: http://nvie.com/posts/a-successful-git-branching-model/ |
|
ups |
|
I think returning the data as Uint8Array would be better than a String since the NFC tag can contain binary data. An array of int or byte would be OK too since that's more consistent with the other API calls in this plugin. Can you make the catch blocks call the callback failure method where appropriate? What if the user wants to authenticate with another key? Should the key be an optional parameter? |
|
the code only work for default key, but is very simple define a key. I code it and upload it if it works |
|
@valemunoz sorry I haven't merged this yet, I'll try to test and merge in the next few weeks. |
|
OMG I completely forget |
modified to read Mifare Classic cards
example call
nfc.readMifare(success,error);
nfc.readMifareSecBloc(sector,block,success,error);