Allow users to opt-out of overdrafting #87
Draft
+80
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To achieve this, there's a new user attribute: can_overdraw. This is enabled by default for all new and existing users. If this is set to false, this user's balance can go below zero. As a first step this throws validation errors which somehow works but is not very user-friendly. Also, this is not yet fully exposed via the API.
This way we can create new alerts in other places that don't disappear by themselves.
nomaster
requested changes
Jan 23, 2020
| @@ -28,4 +28,4 @@ if (navigator.userAgent.match(/(ipod|iphone|ipad)/i)) { | |||
| } | |||
|
|
|||
| //hide notification bars after a few seconds | |||
| $('.alert').delay(10000).fadeOut('slow'); | |||
| $('.flash').delay(10000).fadeOut('slow'); | |||
There was a problem hiding this comment.
Is this related to #88? General UI changes shouldn't happen in this PR.
| @@ -1,4 +1,4 @@ | |||
| - flash.each do |level, message| | |||
| .alert(class="alert-#{level}") | |||
| .flash.alert(class="alert-#{level}") | |||
| @@ -25,17 +45,25 @@ class UserTest < ActiveSupport::TestCase | |||
| end | |||
|
|
|||
| test "should pay" do | |||
| assert users(:one).payment(rand(500)), "Failed to pay" | |||
| assert users(:one).payment(rand(99)), "Failed to pay" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve this there's a new user attribute:
can_overdraw.This is enabled by default for all new and existing users.
If this is set to false, this user's balance can go below zero.
Drinks are hidden from the user page when their price is higher then the user's balance and the user has
can_overdrawdisabled.This is not yet fully exposed via the API - the attribute is returned but can't be changed and the validation is still being performed. This has to be added before merging this PR.