Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fmt type of %T to obj ( time_skew_linux.go) #4378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhanluxianshen
Copy link
Contributor

What problem does this PR solve?

Fix fmt type of %T to obj.

%T: a Go-syntax representation of the type of the value
%t: the word true or false (for booleans)

What's changed and how it works?

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@chaotic-prow
Copy link

chaotic-prow bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andrewmatilde for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 38.75%. Comparing base (38e49da) to head (262edf0).

❗ Current head 262edf0 differs from pull request most recent head 0b39cee. Consider uploading reports for the commit 0b39cee to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4378      +/-   ##
==========================================
+ Coverage   38.71%   38.75%   +0.04%     
==========================================
  Files         169      169              
  Lines       13953    13953              
==========================================
+ Hits         5402     5408       +6     
+ Misses       8103     8097       -6     
  Partials      448      448              
Files Coverage Δ
pkg/time/time_skew_linux.go 35.03% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e49da...0b39cee. Read the comment docs.

@zhanluxianshen zhanluxianshen changed the title Fix fmt type of %T to obj. Fix fmt type of %T to obj ( time_skew_linux.go) Mar 20, 2024
Signed-off-by: zhanluxianshen <zhanluxianshen@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant