Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make rbac.create control creation of all RBAC #4350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miedzinski
Copy link
Contributor

What problem does this PR solve?

This PR fixes rbac.create Helm value, so that it controls creation of all RBAC resources. Previously even with rbac.create=false chaos-daemon and dns-server RBAC were created.

What's changed and how it works?

Added missing if statements to the Helm chart.

Related changes

  • This change also requires further updates to the website (e.g. docs)
  • This change also requires further updates to the UI interface

Cherry-pick to release branches (optional)

This PR should be cherry-picked to the following release branches:

  • release-2.6
  • release-2.5

Checklist

CHANGELOG

Must include at least one of them.

  • I have updated the CHANGELOG.md
  • I have labeled this PR with "no-need-update-changelog"

Tests

Must include at least one of them.

  • Unit test
  • E2E test
  • Manual test

Side effects

  • Breaking backward compatibility

DCO

If you find the DCO check fails, please run commands like below (Depends on the actual situations. For example, if the failed commit isn't the most recent) to fix it:

git commit --amend --signoff
git push --force

@chaotic-prow
Copy link

chaotic-prow bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dcalvin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Dominik Miedziński <dominik.miedzinski@allegro.com>
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4a070b) 38.68% compared to head (a7efc4c) 38.68%.
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4350   +/-   ##
=======================================
  Coverage   38.68%   38.68%           
=======================================
  Files         169      169           
  Lines       13950    13950           
=======================================
  Hits         5397     5397           
- Misses       8105     8107    +2     
+ Partials      448      446    -2     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb84633...a7efc4c. Read the comment docs.

@STRRL STRRL self-assigned this Feb 20, 2024
@g1eny0ung g1eny0ung requested review from STRRL and removed request for dcalvin February 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants