fix: use step increment precision when precisionProp is not specified #7949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 351e033 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
markdowney
force-pushed
the
fix/clamp-precision-when-incrementing
branch
from
2a7e4ed
to
351e033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
When using the
NumberInput, if your value is an Integer (eg: 0 or 1) and you haven't specified a precision,holding down Ctrl or ⌘, and pressing ⬆ or ⬇ should update the value by 0.1 * step, but it doesn't.
⛳️ Current behavior (updates)
Holding down Ctrl or ⌘, and pressing ⬆ or ⬇ doesn't update the value.
🚀 New behavior
Holding down Ctrl or ⌘, and pressing ⬆ or ⬇ increment or decrements the value by 0.1 * step.
💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information