Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): improve attestation push result in table format #797

Merged
merged 6 commits into from
May 20, 2024

Conversation

jiparis
Copy link
Member

@jiparis jiparis commented May 17, 2024

This PR improves the way att push result is shown. It uses now the status action logic (in full mode) before running the actual push to gather all the information from the current attestation.

✗ go run app/cli/main.go --insecure --token $TOKEN att push --key ./cosign.key
WRN API contacted in insecure mode
Enter password for private key:
INF push completed
┌───────────────────┬──────────────────────────────────────┐
│ Initialized At    │ 17 May 24 11:11 UTC                  │
├───────────────────┼──────────────────────────────────────┤
│ Attestation ID    │ efb770a4-203f-4bba-9310-50272e39de26 │
│ Name              │ mywf                                 │
│ Team              │                                      │
│ Project           │ myproj                               │
│ Contract Revision │ 2                                    │
└───────────────────┴──────────────────────────────────────┘
┌─────────────────────────────────────────────────────────────────────────────────────┐
│ Materials                                                                           │
├───────────┬─────────────────────────────────────────────────────────────────────────┤
│ Name      │ foo                                                                     │
│ Type      │ ARTIFACT                                                                │
│ Set       │ Yes                                                                     │
│ Required  │ Yes                                                                     │
│ Is output │ Yes                                                                     │
│ Value     │ contract.json                                                           │
│ Digest    │ sha256:7d2681cd27240354f571b662108ca73c78fb2a6130aa6dc16e04af8905e4c361 │
└───────────┴─────────────────────────────────────────────────────────────────────────┘
INF Attestation Digest: sha256:eea3b1f58ed98b8b548321f850a751b0a8f066fc2cc3734781225a8d6fbc6608

Closes #750

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis requested review from migmartri and javirln May 17, 2024 13:37
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
app/cli/cmd/attestation_init.go Show resolved Hide resolved
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
@jiparis jiparis merged commit c70fd6a into chainloop-dev:main May 20, 2024
13 checks passed
@jiparis jiparis deleted the feat-750 branch May 20, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve att push output
2 participants