Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turns out the
logs
endpoint is:artifacts
endpointRange
馃槧in light of that, add
store
as a required variable for the caller to create, seeing that it must properly be closed as well. this exposes the caller tohttpreaderat
which I don't love, but its simple to implement and seems worth it for easy conditional bufferingthis also changes the return signature to a
*zip.Reader
, since it appears logs are also returned as zip files