Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: add markdown section with Logs Explorer link #326

Closed
wants to merge 2 commits into from

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented May 2, 2024

Screenshot 2024-05-02 at 4 50 48 PM

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh requested a review from k4leung4 May 2, 2024 23:50
Copy link
Contributor

@k4leung4 k4leung4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there cases where we wouldnt want the logurl markdown?
im wondering if it makes sense to provide a markdown module with logurl defaulted to avoid duplication

please fix presubmit

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Copy link
Member Author

imjasonh commented May 9, 2024

are there cases where we wouldnt want the logurl markdown? im wondering if it makes sense to provide a markdown module with logurl defaulted to avoid duplication

I can't think of any, AFAIK we have the logs panel in all these dashboards already. We'll probably need to figure out how to pass custom markdown to these dashboards, like for playbooks etc., but that can happen in a future PR.

...Or it can happen in this PR, if we have ideas about how that should work. 😆

@imjasonh
Copy link
Member Author

Deferring this for now. If we want it we can resurrect.

@imjasonh imjasonh closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants