Attempt to filter out default values from dashboard sections. #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default values are zero-ed out by the APIs, causing lots of diffs between wat's live and what's being proposed. This changes the behavior to zero out known common fields.
k4leung4
reviewed
Apr 23, 2024
| groupByFields = var.denominator_group_by_fields | ||
| perSeriesAligner = var.denominator_align == local.default_align ? null : var.denominator_align | ||
| crossSeriesReducer = var.denominator_reduce == local.default_reduce ? null : var.denominator_reduce | ||
| groupByFields = length(var.denominator_group_by_fields) |
my advice for testing this is to spin up the stack in your own project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default values are zero-ed out by the APIs, causing lots of diffs between wat's live and what's being proposed.
This changes the behavior to zero out known common fields.
I wasn't able to test this out effectively locally on any existing setups with
dev_overrides. If you have any tips for how to develop locally let me know! 馃檹