DNM: WIP dagger integration. #905
Conversation
Signed-off-by: Dan Lorenc <dlorenc@chainguard.dev>
| return err | ||
| } | ||
|
|
||
| // TestUsability determines if the Bubblewrap runner can be used |
| } | ||
|
|
||
| // TerminatePod terminates a pod if necessary. Not implemented | ||
| // for Bubblewrap runners. |
| return nil, nil | ||
| } | ||
|
|
||
| // WorkspaceTar implements Runner |
| return "", err | ||
| } | ||
|
|
||
| ref, err := name.ParseReference("melange:latest") |
There was a problem hiding this comment.
I could see having a fixed name here creating races in the load/run phase when performing multiple builds locally.
There was a problem hiding this comment.
I think this is just at throwaway name but could be wrong.
| } | ||
|
|
||
| tarPath := filepath.Join(d.tmpDir, imageTarName) | ||
| if err := tarball.WriteToFile(tarPath, ref, img); err != nil { |
There was a problem hiding this comment.
This will be really inefficient. I need to look to see if dagger exposes a better interface.
There was a problem hiding this comment.
Yea, I know. I think the only better option is to round trip through a registry. I looked and couldn't find much else.
There was a problem hiding this comment.
OR change the entire setup so dagger also invokes apko for us.
| // TestUsability determines if the Bubblewrap runner can be used | ||
| // as a container runner. | ||
| func (d *daggerRunner) TestUsability(ctx context.Context) bool { | ||
| return true |
There was a problem hiding this comment.
I think the sdk exposes a simple health check somewhere we could leverage here
Melange Pull Request Template
Functional Changes
Notes:
SCA Changes
Notes:
Linter
Notes: