Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate pipeline fields together #748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imjasonh
Copy link
Member

I spent an embarrassing amount of time trying to debug why this failed:

- runs: autoconf/make
  with:
    opts: operator

When I figured it out, I wanted an error to stop me from making that mistake again.

This is incomplete, there are other combinations of pipeline fields that should be an error, but this is a start at least.

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Copy link
Member Author

It looks like tini.yaml does this in Wolfi: https://github.com/wolfi-dev/os/blob/main/tini.yaml

I'm not sure if this is a bug, and that opts: are just ignored in this case. If that's so, it's even clearer this should be an error so folks don't point this footgun at themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant