Add build-gpep517 pipeline for Python #663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Furkan Türkal <furkan.turkal@chainguard.dev>
joshrwolf
reviewed
Sep 6, 2023
joshrwolf
previously approved these changes
Sep 6, 2023
kaniini
reviewed
Sep 6, 2023
kaniini
reviewed
Sep 6, 2023
developer-guy
force-pushed
the
python-pipeline-gpep517
branch
from
46d6b5b
to
83a1f6b
Compare
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
developer-guy
force-pushed
the
python-pipeline-gpep517
branch
from
83a1f6b
to
1a94b1b
Compare
|
Why not just use |
Hmmm, how can we be sure that it won't break the existing as-is flow? I was thinking to invoke |
|
Any thoughts? @kaniini Does it make sense to check |
|
How should we proceed here? cc @imjasonh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Python pipeline called:
python/build-gpep517.In case if upstream project does not provide neither
pyproject.tomlorsetup.py, sopython/buildandpython/build-wheelpipelines does not work as expected since both pipelines usesbuildmodule and depends on aforementioned files to run correctly. Invoking thepython-buildwith-m gpep517rather than-m build, resolves this issue.