Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was flummoxed to find that
go test ./...
was both very slow and did not work. The very slowness comes from a couple sources. One is that we use a 1 QPS rate limiter in a lot of places, even when we are using an in-process http server to serve up testdata. I've removed those instances. In one particular python test, we are fetching a 10MB targz from the internet twice. I've gated that behind ane2e
build tag, so to run that test you need to execute:go test -tags e2e ./...
That's cumbersome, so I've added it to the
make test
target.I've also added the
e2e
build tag to the go fips generated APK test because it requires you to first generate a binary before the test will pass. This is unacceptable to me, so themake test
target will still test that, butgo test ./...
will not.Before:
After: