Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melange bump: don't skip main git checkout when mangled package versio… #1187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rawlingsj
Copy link
Member

@rawlingsj rawlingsj commented May 2, 2024

…n is used

There are cases where we use a mangled package version var when doing a git checkout of the main source repo. Let's update the git commit in these cases. The check was originally added in #975 but only identified the main repo using ${{package.version}}, we should include ${{vars.mangled-package-version}}.

The reason is so the update bot doesn't bump all commits if there are multiple git checkout steps, as they are likely not the ones that the update: block is configured for.

There may be a better way to identify the main git checkout, not sure of one now though.

…n is used

Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
@rawlingsj
Copy link
Member Author

fyi @xnox

@xnox
Copy link
Contributor

xnox commented May 2, 2024

Scope of change:

$ echo $(git grep 'tag:.*vars.mangled-package-version' | wc -l)
29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants