Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only consider files in expected path (not under) for cmd provides. #1136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smoser
Copy link
Contributor

@smoser smoser commented Apr 12, 2024

Anything with +x in usr/bin/.../node_modules/... was getting marked as a command provided by the apk.

Instead, of considering any path under usr/bin, only consider usr/bin/.

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

Anything with +x in usr/bin/.../node_modules/... was getting
marked as a command provided by the apk.

Instead, of considering any path under usr/bin, only consider usr/bin/.
@smoser
Copy link
Contributor Author

smoser commented May 3, 2024

closing this, i guess i oepned it twice.
prefer https://github.com/chainguard-dev/melange/pull/1164/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant