Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify sign key default value, fixes #1114 #1115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

unify sign key default value, fixes #1114 #1115

wants to merge 1 commit into from

Conversation

shyim
Copy link

@shyim shyim commented Mar 30, 2024

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

@shyim
unify sign key default value, fixes chainguard-dev#1114
2aac675 
Signed-off-by: Soner Sayakci <s.sayakci@shopware.com>
@shyim
Copy link
Author

shyim commented Mar 30, 2024

Enforce - Commit Signing seems not to support ssh based git signing. Is that a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shyim