Add filter-prefix option to update config. #1083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
feature/filter-prefix-update
branch
from
b04c42e
to
ec49063
Compare
There is not currently a way to include only matching versions from the release update service This adds filter-prefix entry to Update section of melange.yaml. Specific use case for filter-prefix is a streamed package (ruby). After the corresponding change to make use of this filter lands in wolfi, then we can update ruby-3.2 to enable the release monitor like with: > update: > enabled: true > manual: true > filter-prefix: "3.2." > release-monitor: > identifier: 4223 Signed-off-by: Scott Moser <smoser@brickies.net>
smoser
force-pushed
the
feature/filter-prefix-update
branch
from
ec49063
to
ee4923d
Compare
smoser
added a commit
to smoser/wolfictl
that referenced
this pull request
Mar 12, 2024
This relies on chainguard-dev/melange#1083 And allows adding an "include prefix" for update checks.
rawlingsj
reviewed
Mar 12, 2024
| @@ -459,6 +459,8 @@ type Update struct { | |||
| GitHubMonitor *GitHubMonitor `json:"github,omitempty" yaml:"github,omitempty"` | |||
| // The configuration block for transforming the `package.version` into an APK version | |||
| VersionTransform []VersionTransform `json:"version-transform,omitempty" yaml:"version-transform,omitempty"` | |||
| // Prefix filter to apply when searching releases | |||
| FilterPrefix string `json:"filter-prefix,omitempty" yaml:"filter-prefix,omitempty"` | |||
There was a problem hiding this comment.
I wonder if putting it under the update block will cause confusion with the existing filter-prefix that is under the github block? I.e. would it be better if we move this under the release-monitor block?
There was a problem hiding this comment.
Or maybe Deprecate the 'TagFilterPrefix' in github block? filtering strings isn't really "provider specific".
I'm happy to do whatever you think is right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not currently a way to include only matching versions from the release update service
This adds filter-prefix entry to Update section of melange.yaml. Specific use case for filter-prefix is a streamed package (ruby).
After the corresponding change to make use of this filter lands in wolfi, then we can update ruby-3.2 to enable the release monitor like with:
Melange Pull Request Template
Functional Changes
Notes:
SCA Changes
Notes:
Linter
Notes: