apk,signature: add support to verify RSA256 signed Index #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support to correctly parse signature stream that contains multiple types of signatures. This also refactors signing to allow trivially changing signature type, and to have multiple if so desired. See code comments for lots of caveats. Once all tools upgrade to this version of the module, signing can be changed from RSA to RSA256. Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to correctly parse signature stream that contains multiple types of signatures. This also refactors signing to allow trivially changing signature type, and to have multiple if so desired.
See code comments for lots of caveats.
Once all tools upgrade to this version of the module, signing can be changed from RSA to RSA256.
apk-tools supports RSA256 since v2.7.0 (2017).
abuild-sign support proposed in https://gitlab.alpinelinux.org/alpine/abuild/-/merge_requests/290/diffs