New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for new functionality #215
Conversation
pkg/action/oci_test.go
Outdated
} | ||
|
||
var out bytes.Buffer | ||
md, err := render.New("markdown", &out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to use the simple
renderer? The output is more stable and lower maintenance for tests that don't require markdown specific testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in: 3b11939
(#215).
Signed-off-by: Evan Gibler <keybase@egibs.xyz>
A lot of new functionality has been added recently and the testing gaps were piling up.
This PR covers a decent bit of the newly-added functionality by testing the following cases:
tar
,gzip
, andzip
extraction functions.tar.gz
with a.tar.gz
file inside of it)To support some of these test cases, I uploaded archives for each portion of the functionality and an output file with the expected scan results when testing the relevant case.
All of the new tests are passing locally and should in CI as well:
This PR also adds a small test for the new profiling feature.