Add version support #210
Merged
Add version support #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 10, 2024 09:22
Signed-off-by: Evan Gibler <keybase@egibs.xyz>
tstromberg
requested changes
May 13, 2024
There was a problem hiding this comment.
I like this feature, but would prefer if it could be done in such a way that it still works if you run:
go install . && cd /tmp && bincapz --version
What do you think about moving the version string out of the VERSION file and into a const - for instance version.ID?
added 2 commits
May 13, 2024 14:41
Signed-off-by: Evan Gibler <keybase@egibs.xyz>
tstromberg
reviewed
May 13, 2024
VERSION
Outdated
| @@ -0,0 +1 @@ | |||
| 0.11.0 | |||
There was a problem hiding this comment.
I think we can get rid of this now.
There was a problem hiding this comment.
Removed in 5be38e1 (#210).
added 2 commits
May 13, 2024 14:42
tstromberg
reviewed
May 13, 2024
bincapz.go
Outdated
| @@ -50,6 +51,8 @@ func main() { | |||
| statsFlag := flag.Bool("stats", false, "Show statistics about the scan") | |||
| thirdPartyFlag := flag.Bool("third-party", true, "Include third-party rules, which may have licensing restrictions") | |||
| verboseFlag := flag.Bool("verbose", false, "Emit verbose logging messages to stderr") | |||
| versionFlag := flag.Bool("version", false, "show version information") | |||
There was a problem hiding this comment.
Capitalize "Show" for consistency with your more recent flag changes.
There was a problem hiding this comment.
Fixed in 9b582f9 (#210).
tstromberg
approved these changes
May 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #209
This PR adds support for a
--versionflag that will either use the newly-addedVERSIONfile or check for themain.versionbuild key.Testing:
We aren't publishing binaries yet but this should work the same if we use the
VERSIONfile as the source of truth; however, this file will need to be updated prior to any new releases being cut.If there's a better way to handle this I'm all ears!