Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT indicator in CachePopup #15518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DT indicator in CachePopup #15518

wants to merge 1 commit into from

Conversation

ztNFny
Copy link
Contributor

@ztNFny ztNFny commented Mar 25, 2024

A quick stab at adding the circle marker to popup to fix #15505
image

@eddiemuc
Copy link
Contributor

I like it.
Maybe a tiny bit larger?

@ztNFny
Copy link
Contributor Author

ztNFny commented Mar 25, 2024

I like it.
Maybe a tiny bit larger?

Not easily done. The scaling is hardcoded in MapMarkerUtils.

I can do it afterwards if this PR is well received, otherwise too much work to invest.

@bekuno
Copy link
Member

bekuno commented Mar 25, 2024

I think that is would be better between D and T.

@SammysHP
Copy link
Member

Also D and T are kind of redundant with the labels. Not sure what lead to the removal of the stars, but I think the numbers plus a graphical representation like the stars or a bar graph would be better.

Of course this PR is still an improvement!

@moving-bits
Copy link
Member

while I see the resemblance with the markers on the map, I think the visual identifier is too small here, so not that much gain over the pure textual representation. IMHO the proposal of @bekuno given in #15505 (comment) would be easier to grap quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users missing the stars for D/T on the map sheet
5 participants