Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users missing the stars for D/T on the map sheet #15505

Open
Lineflyer opened this issue Mar 23, 2024 · 13 comments · May be fixed by #15518
Open

Users missing the stars for D/T on the map sheet #15505

Lineflyer opened this issue Mar 23, 2024 · 13 comments · May be fixed by #15518
Labels
Feedback required Issue requires feedback of the author or another user Frontend Design User Interface problems

Comments

@Lineflyer
Copy link
Member

Lineflyer commented Mar 23, 2024

I discussed with a bunch of users, which are a bit disappointed regarding the change from popup to bottom sheet.
While at first they claimed a smaller font (which turned out not to be the case) later it turned out, what they were really missing is the better readability of D/T represented by stars.

Some users now instead use the D/T-icons on the map, but its still not the same for them.

I have to somewhat agree, that it easier/faster to recognize D- and T-values if they are presented graphically.
Not sure if we want and can find a solution which is more graphical for D/T but still compact for the bottom sheet.

@Lineflyer Lineflyer added Frontend Design User Interface problems Feedback required Issue requires feedback of the author or another user labels Mar 23, 2024
@moving-bits
Copy link
Member

How about putting it in the same line, eg: D 5.0 ***** (separator) T 2.0 **
This would keep it compact, and if the screen is too small, the textual "T 2.0" should still be visible. (to be tested)

@ztNFny
Copy link
Contributor

ztNFny commented Mar 23, 2024

How about putting it in the same line, eg: D 5.0 ***** (separator) T 2.0 ** This would keep it compact, and if the screen is too small, the textual "T 2.0" should still be visible. (to be tested)

how about "D 5.0 / T 2.0 - ***** / **"? That way it's easier to handle overflow and it also ensures that texts are always in the same position (where the user expects them to be).

Or maybe show the marker in line with the rating instead of the stars?

My personal vote would be for not re-adding the stars, I also removed them in DetailsActivity in my builds - but I have my own builds, so I don't have any strong opinion on this ;-)

@bekuno
Copy link
Member

bekuno commented Mar 24, 2024

Instead to use stars I propose to use a colored background in the colors already used for the cache D/T info, eg.
grafik
Perhaps we could use only part of it instead of the full colouring, analogous to the circle representation. But then we have to be aware of the theme colour.

@Lineflyer
Copy link
Member Author

Instead to use stars I propose to use a colored background in the colors already used for the cache D/T info, eg.

Sounds like a good space saving ideas and would allow to visualize D/T at first sight.
Only the styling needs to be well done to be readable on white/black theme (as you said).

@ztNFny
Copy link
Contributor

ztNFny commented Mar 24, 2024

A quick stab at adding the circle marker to popup:
image

@ztNFny ztNFny linked a pull request Mar 25, 2024 that will close this issue
@moving-bits moving-bits added this to To do in Cache / waypoint info sheets via automation Mar 27, 2024
@moving-bits moving-bits moved this from To do to In progress in Cache / waypoint info sheets Mar 28, 2024
@MagpieFourtyTwo
Copy link

If you are considering coloring, please keep in mind that nearly 10 in 100 men are colorblind or have at least a color vision deficiency, which makes it at least pretty hard to distinguish esp. between green, brown and red.

With the map's D/T icons that's no big deal, cause there is additionally the different "fill level", but with completely filled rectangles, which just differ in color, they will gain nothing.

Therefore I would suggest a similar solution like with the 5+5 stars, which are either filled or just outlined. And if stars are not possible for whatever reason (what about UTF-8?), then maybe just 5+5 squares, either full, half, or not at all filled.

@moving-bits
Copy link
Member

For reference: We could use the following code points:

  • ★ U+2605 (filled star)
  • ☆ U+2606 (outlined star)
  • ⯪ U+2BEA (left half filled, right half outlined star)

but need to check first whether they are all available on our targeted API versions, especially the half/half variant. If chars are not available on targeted systems, we should stay with our icons for now.

@ztNFny
Copy link
Contributor

ztNFny commented May 12, 2024

Unicode would be suboptimal as they Look different depending on the font (vendor), for such a prominent feature we should be in control what it looks like.

@MagpieFourtyTwo
Copy link

What about forcing the font for this string?

@MagpieFourtyTwo
Copy link

we should stay with our icons for now.

Thought these are not possible in the bottom sheeet ... *wonder*
If I misunderstood, so why not just do it the same way it is in the listing's detail page?

@moving-bits
Copy link
Member

moving-bits commented May 19, 2024

so why not just do it the same way it is in the listing's detail page?

this would consume two lines of precious space, for an information that's already there, though just in textual form

I played a bit with putting D/T stars into a single line:

image

But this probably wraps on most devices (smaller screen and/or larger fonts), then taking up same space as on cache details page, but being less readable in that case:

image

(Sure, one could make wrap the text together with its accompanying rating stars, but it still consumes too much space then, IMHO.)

Thus I would say, pursue one of the following variants:

@ztNFny
Copy link
Contributor

ztNFny commented May 19, 2024

My vote goes to circle marker. Small but has all the info at a glance, it's a familiar element and compatible with colour blind.

@MagpieFourtyTwo
Copy link

I don't really agree that space is such an issue for the bottom sheet, IMO there's plenty of map room left above it, so one line more or less should not be a big problem. And although I admittedly don't know how the bottom sheet behaves on smaller displays (6.8" over here, but are there really still displays out there with less than, let's say 4"?), thus there should always be enough space above the bottom sheet to click in the map (in order to close the bottom sheet again). And for much more than that even I don't use the map space above it - and over here the map space is even bigger than the space the bottom sheet occupies right now.

Thus I still favor the two-lines-with-text-plus-stars solution for three reasons:

  1. info can easily be seen and understood, even at a glance
  2. users are used to it from the listing page
  3. their reaction seems to show that they really want these stars, so why not? ;)

But if the general opinion is that space is nonetheless a problem, then I would also opt for the circle marking.
Because both, values and stars, in one line are even more difficult to read than just the plain values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback required Issue requires feedback of the author or another user Frontend Design User Interface problems
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

5 participants