Skip to content

Commit

Permalink
Merge pull request #8385 from cfpb/ans_remove_icon_link
Browse files Browse the repository at this point in the history
Remove unused `icon-link` class | update jump link class
  • Loading branch information
anselmbradford committed May 9, 2024
2 parents 7b164ec + 96103c4 commit 7a61a60
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 19 deletions.
Expand Up @@ -262,7 +262,7 @@ <h2>Distance</h2>
<div class="col">
<h2 class="cfpb_visually_hide">Agency</h2>
<div class="hud_hca_api_counselor">
<a href="{{ counselor.weburl }}" class="icon-link icon-link__external-link"><span class="icon-link_text">{{ counselor.nme }}</span></a>
<a href="{{ counselor.weburl }}">{{ counselor.nme }}</a>
</div>
<div class="hud_hca_api_counselor_address">
<span class="hud_hca_api_adr">
Expand All @@ -275,7 +275,7 @@ <h2 class="cfpb_visually_hide">Agency</h2>
</div>
<div class="hud_hca_api_counselor_meta">
<span class="hud_hca_api_results_listing_title">Website: <span class="hud_hca_api_site">
<a href="{{ counselor.weburl }}" class="icon-link icon-link__external-link"><span class="icon-link_text">{{ counselor.weburl }}</span></a>
<a href="{{ counselor.weburl }}">{{ counselor.weburl }}</a>
</span></span>
<span class="hud_hca_api_results_listing_title">Phone: <span class="hud_hca_api_tel">{{ counselor.phone1}}</span></span>
<span class="hud_hca_api_results_listing_title">Email Address: <span class="hud_hca_api_email">
Expand Down
16 changes: 8 additions & 8 deletions cfgov/jinja2/know-before-you-owe/compare/index.html
Expand Up @@ -96,8 +96,8 @@ <h3>Initial TIL disclosure + Good Faith Estimate</h3>
<img src="https://files.consumerfinance.gov/f/201207_cfpb_img_t-gfe3.png" alt="Loan estimate, before, Good Faith Estimate, page 3" title="Click to enlarge"> </a>
</div>
<p>
<a href="https://files.consumerfinance.gov/f/201207_combined_til_gfe.pdf" class="jump-link icon-link icon-link__download">
<span class="jump-link_text">View these two forms as a PDF</span></a>
<a href="https://files.consumerfinance.gov/f/201207_combined_til_gfe.pdf" class="a-link a-link--jump a-link--icon-after-text">
<span class="a-link__text">View these two forms as a PDF</span></a>
</p>
</div>
<!-- /.grid_col-6 -->
Expand All @@ -113,8 +113,8 @@ <h3>Loan Estimate</h3>
<img src="https://files.consumerfinance.gov/f/201311_cfpb_le_small_page3.png" alt="Loan Estimate page 3" title="Click to enlarge"> </a>
</div>
<p>
<a href="https://files.consumerfinance.gov/f/201311_cfpb_kbyo_loan-estimate.pdf" class="jump-link icon-link icon-link__download">
<span class="jump-link_text">View the Loan Estimate as a PDF</span></a>
<a href="https://files.consumerfinance.gov/f/201311_cfpb_kbyo_loan-estimate.pdf" class="a-link a-link--jump a-link--icon-after-text">
<span class="a-link__text">View the Loan Estimate as a PDF</span></a>
</p>
</div>
</div>
Expand All @@ -136,8 +136,8 @@ <h3>Final TIL disclosure + HUD-1 Settlement Statement</h3>
<img src="https://files.consumerfinance.gov/f/201207_cfpb_img_t-hud1_3.png" alt="Closing disclosure, before, HUD-1, page 3" title="Click to enlarge"> </a>
</div>
<p>
<a href="https://files.consumerfinance.gov/f/201207_combined_til_hud1.pdf" class="jump-link icon-link icon-link__download">
<span class="jump-link_text">View these two forms as a PDF</span></a>
<a href="https://files.consumerfinance.gov/f/201207_combined_til_hud1.pdf" class="a-link a-link--jump a-link--icon-after-text">
<span class="a-link__text">View these two forms as a PDF</span></a>
</p>
</div>
<div class="kbyo-compare-col">
Expand All @@ -156,8 +156,8 @@ <h3>Closing Disclosure</h3>
<img src="https://files.consumerfinance.gov/f/201311_cfpb_cd_small_page5.png" alt="Closing Disclosure page 5" title="Click to enlarge"> </a>
</div>
<p>
<a href="https://files.consumerfinance.gov/f/201311_cfpb_kbyo_closing-disclosure.pdf" class="jump-link icon-link icon-link__download">
<span class="jump-link_text">View the Closing Disclosure as a PDF</span></a>
<a href="https://files.consumerfinance.gov/f/201311_cfpb_kbyo_closing-disclosure.pdf" class="a-link a-link--jump a-link--icon-after-text">
<span class="a-link__text">View the Closing Disclosure as a PDF</span></a>
</p>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion cfgov/jinja2/know-before-you-owe/timeline/index.html
Expand Up @@ -107,7 +107,7 @@ <h3 class="h5">Disclosures tested:</h3>
<br>
<a class="a-link
a-link--icon"
href="https://files.consumerfinance.gov/f/201106_cfpb_mortgage-disclosure-prototype-Round2-Redbud.pdf" class="icon-link icon-link__download">
href="https://files.consumerfinance.gov/f/201106_cfpb_mortgage-disclosure-prototype-Round2-Redbud.pdf">
<span class="a-link__text">Prototype A</span>
{{ svg_icon('download') }}
</a>
Expand Down
5 changes: 2 additions & 3 deletions cfgov/v1/jinja2/v1/includes/organisms/chart.html
Expand Up @@ -43,9 +43,8 @@ <h3>{{ value.title }}</h3>
<strong>Download:</strong>
{# Note: link closing tag needs to be on the same line to avoid a
trailing space in the link. #}
<a class="icon-link icon-link__download"
href="https://files.consumerfinance.gov/data/{{ value.data_source }}">
<span class="icon-link_text">CSV file</span></a>
<a href="https://files.consumerfinance.gov/data/{{ value.data_source }}">
CSV file</a>
<br>
{% endif %}

Expand Down
2 changes: 1 addition & 1 deletion cfgov/v1/jinja2/v1/includes/organisms/mortgage-chart.html
Expand Up @@ -171,7 +171,7 @@ <h3 id="mp-line-chart-title">Percentage of mortgages {{ time_frame_styled }} {%
<p class="m-chart-footnote block--sub block--border-top block short-desc">
<strong>Source:</strong> National Mortgage Database<br>
<strong>Date published:</strong> {{ pub_date_formatted }}<br>
<strong>Downloads:</strong> CSV files with data by <a class="icon-link icon-link__download" href="{{ state_meta['url'] }}" <span class="icon-link_text">state</span></a> ({{ state_meta['size'] }}), <a class="icon-link icon-link__download" href="{{ metro_meta['url'] }}" <span class="icon-link_text">metro and non-metro areas</span></a> ({{ metro_meta['size'] }}), or <a class="icon-link icon-link__download" href="{{ county_meta['url'] }}"><span class="icon-link_text">county</span></a> ({{ county_meta['size'] }}).<br>
<strong>Downloads:</strong> CSV files with data by <a href="{{ state_meta['url'] }}">state</a> ({{ state_meta['size'] }}), <a href="{{ metro_meta['url'] }}">metro and non-metro areas</a> ({{ metro_meta['size'] }}), or <a href="{{ county_meta['url'] }}">county</a> ({{ county_meta['size'] }}).<br>
{% if value.note %}<strong>Note:</strong> {{ value.note }} <a href="/data-research/mortgage-performance-trends/about-the-data/">Learn more about the data</a>.<br>{% endif %}
</p>
</div>
2 changes: 1 addition & 1 deletion cfgov/v1/jinja2/v1/includes/organisms/mortgage-map.html
Expand Up @@ -210,7 +210,7 @@ <h3 id="mp-map-title">Percentage of mortgages {% if time_frame == '90' %} at lea
<p class="m-chart-footnote block--sub block short-desc">
<strong>Source:</strong> National Mortgage Database<br>
<strong>Date published:</strong> {{ pub_date_formatted }}<br>
<strong>Downloads:</strong> CSV files with data by <a class="icon-link icon-link__download" href="{{ state_meta['url'] }}" <span class="icon-link_text">state</span></a> ({{ state_meta['size'] }}), <a class="icon-link icon-link__download" href="{{ metro_meta['url'] }}" <span class="icon-link_text">metro and non-metro areas</span></a> ({{ metro_meta['size'] }}), or <a class="icon-link icon-link__download" href="{{ county_meta['url'] }}"><span class="icon-link_text">county</span></a> ({{ county_meta['size'] }}).<br>
<strong>Downloads:</strong> CSV files with data by <a href="{{ state_meta['url'] }}">state</a> ({{ state_meta['size'] }}), <a href="{{ metro_meta['url'] }}">metro and non-metro areas</a> ({{ metro_meta['size'] }}), or <a href="{{ county_meta['url'] }}">county</a> ({{ county_meta['size'] }}).<br>
{% if value.note %}<strong>Note:</strong> {{ value.note }} <a href="/data-research/mortgage-performance-trends/about-the-data/">Learn more about the data</a>.<br>{% endif %}
</p>
</div>
5 changes: 2 additions & 3 deletions cfgov/v1/jinja2/v1/includes/organisms/simple-chart.html
Expand Up @@ -66,9 +66,8 @@ <h5>Figure {{ value.figure_number }}</h5>
{% set href = make_download_href(value.download_file, data_location) %}
{% if href %}
<strong>Download:</strong>
<a class="icon-link icon-link__download"
href="{{href}}">
<span class="icon-link_text">{{value.download_text}}</span></a><br>
<a href="{{href}}">
{{value.download_text}}</a><br>
{% endif %}
{% endif %}
{% if value.notes%}<strong>Notes:</strong> {{value.notes}}{% endif %}
Expand Down

0 comments on commit 7a61a60

Please sign in to comment.