Cached configuration source with thread safety #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
each access to a property read the configuration file, so with many access in many requests, the access time can be important. More, if configuration file changes while a thread access to a property, next access in same thread can produce incoherence.
It's for this reason we created CachedConfigurationSource, using AtomicReference to contains properties and ensure thread safety.
I hope that will be useful.
Denis