Fix consul value fetch #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Andrew, I was wondering if you could update your PR to make it work with #148. Sorry for taking so long to release this but I had a lot of distractions recently. |
MaartenR
pushed a commit
to MaartenR/cfg4j
that referenced
this pull request
Aug 24, 2017
…repo) and changed artifact id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for the issue I raised in #144
Here I choose to not change the contract provided by the Reloadable interface, since it wouldn't make sense in other contexts.
Instead in ConsulConfigurationSourceBuilder you can optionally provide an Environment which will be used to only fetch values given your Environment context instead of all of the values in Consul. If you don't provide an Environment it defaults back to it's old behavior.