-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add back package signing #9913
add back package signing #9913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for also doing the Windows installer clean up here! I will look into the site reference for it as well this week.
awesome. thanks for the review! i think there's more installer cleanup work we could do as it's still being built in CI, however, we're no longer publishing it or using the CSS |
this fixes #9740
the diff isn't actually that large as moving some of the contents of the old deploy-stage.yml file to the new common-deploy-jobs.yml file accounts for almost half of the added and removed lines here. i also tried to convince git that deploy-stage.yml was renamed to nightly-deploy-stage.yml, but the diff is too much for git to believe me. that fact might be helpful when reviewing this though
i went ahead and removed publishing the windows installer from the release script as part of this pr so we can avoid trying to create the github release twice. i believe further windows installer cleanup work is being done as part of #9897
to test this pr, i did a dummy 2.10.0 release off of this branch like
doing that resulted in this ci run and this github release (which you can only see if you're logged into github and have the credentials to do so as i made it a draft for testing purposes)
if this pr is merged, i will also
releases/le*/packages/{*.tar.gz,*.whl}
as the PyPI upload pathafter this pr, we could also pretty easily automate uploading to pypi from ci as well, but if we do that, i think it should be done in another pr