Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webroot delay #9650

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

osirisinferi
Copy link
Collaborator

Fixes #9643.

Not sure if the documentation needs to be updated. I don't think this option will be used very often.

Pull Request Checklist

  • The Certbot team has recently expressed interest in reviewing a PR for this. If not, this PR may be closed due our limited resources and need to prioritize how we spend them.
  • If the change being made is to a distributed component, edit the master section of certbot/CHANGELOG.md to include a description of the change being made.
  • Add or update any documentation as needed to support the changes in this PR.

Copy link
Collaborator

@alexzorin alexzorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm not so sure whether this feature is worth adding.

I don't think the use case discussed in #9643 warrants the change or that Certbot should go out of its way to cater to such setups.

Tomcat might justify things, but it's probably single/double-digit users and there's a relatively straightforward server.xml workaround. I think the realer problem with Tomcat is the lack of good documentation about how to use it with Certbot.

The only thing in favor of this flag is that it's simple.

certbot/certbot/_internal/plugins/webroot.py Outdated Show resolved Hide resolved
@osirisinferi
Copy link
Collaborator Author

I'm not so sure whether this feature is worth adding.

I can understand that, use case probably isn't large indeed, I won't feel offended if you'd close this PR. 😛 But as the issue wasn't closed as "won't fix", I thought I'd just throw the PR together anyway 🙂

@alexzorin alexzorin added the priority: unplanned Work that we believe should be done, but does not have a higher priority. label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: unplanned Work that we believe should be done, but does not have a higher priority.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webroot: renew propagation-seconds
2 participants