Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make nginx tests internal #9638

Merged
merged 1 commit into from
Mar 28, 2023
Merged

make nginx tests internal #9638

merged 1 commit into from
Mar 28, 2023

Conversation

bmw
Copy link
Member

@bmw bmw commented Mar 28, 2023

This is the certbot-nginx version of #9625.

alexzorin
alexzorin approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@alexzorin alexzorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can probably delete boulder-integration.conf.sh because it seems to have been superseded by equivalent functionality in certbot-ci.

@bmw bmw merged commit 9e30e8a into master Mar 28, 2023
@bmw bmw deleted the move-nginx-tests branch March 28, 2023 22:01
@bmw bmw mentioned this pull request Mar 28, 2023
Merged
@bmw
Copy link
Member Author

bmw commented Mar 28, 2023

We sure can! I did that in #9640 to avoid another review cycle here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzorin alexzorin alexzorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmw @alexzorin