Make apache tests internal #9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzorin
requested changes
Mar 28, 2023
| recursive-include certbot_apache/_internal/augeas_lens *.aug | ||
| recursive-include certbot_apache/_internal/tls_configs *.conf | ||
| recursive-include certbot_apache/_internal/tests/testdata * |
There was a problem hiding this comment.
Is certbot_apache/_internal/tests/apache-conf-files omitted intentionally?
I also notice that certbot_apache/_internal/augeas_lens/README is omitted, though that's not new here.
There was a problem hiding this comment.
Yeah I did that on purpose. We didn't use to ship it, but we started as a side effect of #7607 and I don't think it's something we should do. Those tests are super hacky and apache-conf-test-pebble.py relies on things like certbot-ci which we have never shipped.
alexzorin
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the certbot-apache version of #9625.