Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid pyOpenSSL 23.1.0 #9631

Merged
merged 1 commit into from
Mar 27, 2023
Merged

avoid pyOpenSSL 23.1.0 #9631

merged 1 commit into from
Mar 27, 2023

Conversation

alexzorin
Copy link
Collaborator

Our NO_PIN test fails due to pyca/pyopenssl#1199.

This PR might strictly not be necessary once a new release of PyOpenSSL is available? I suppose it depends whether they yank the release.

Copy link
Member

@bmw bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! I think us merging this is fine. We can always change or remove it in the future if we want.

@bmw bmw merged commit f004383 into master Mar 27, 2023
@bmw bmw deleted the prohibit-pyOpenSSL-23-1-0 branch March 27, 2023 18:27
@alex
Copy link
Collaborator

alex commented Mar 27, 2023

Hey, I don't think we changed the behavior of get_short_name in the last 10 years :-) Do you have better insight into why reverting to an older pyOpenSSL solves this?

@alexzorin
Copy link
Collaborator Author

I took a closer look:

The regression is in OpenSSL 3.1.0. cryptography>=40.0.0 wheels are the first to be compiled using OpenSSL 3.1.0, and pyOpenSSL==23.1.0 was the first version to be compatible with cryptography>40,<41.

If I understand what's happening, once there is a new release of OpenSSL and cryptography wheel using that release, we can get rid of the constraint.

@alex
Copy link
Collaborator

alex commented Mar 27, 2023 via email

@alex
Copy link
Collaborator

alex commented Mar 28, 2023

We've now released a new pyopenssl, and confirmed that it works. Because you just did a != check, I don't think you have any additional requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants