Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns-route53: add --dns-route53-map #9623

Closed
wants to merge 4 commits into from
Closed

dns-route53: add --dns-route53-map #9623

wants to merge 4 commits into from

Conversation

alexzorin
Copy link
Collaborator

Fixes #9030. I noticed that this issue has come up again for a couple of users recently. There is no good workaround.

@bmw
Copy link
Member

bmw commented Mar 30, 2023

I don't love the (minor) added complexity for what feels like a fairly niche use case, but it may indeed be worth it and not be that niche if people keep hitting this.

I'm not super against this approach or anything, but I'm curious if you considered option (a) from #9030 (comment) and if so what you didn't like about it. If we did that, I think we may have to be careful about regressions so maybe we'd try to update every zone with same specificity, catching errors, and proceeding as long as at least one update succeeds, but it otherwise feels like that approach should just work for people and they wouldn't have to spend any time thinking about or configuring this for Certbot.

What do you think?

@bmw bmw assigned alexzorin and bmw Mar 30, 2023
@alexzorin
Copy link
Collaborator Author

I agree that option (a) is clearly preferable. I can't remember why I chose otherwise. Thanks!

@alexzorin alexzorin closed this Mar 30, 2023
@alexzorin alexzorin deleted the route53-map branch March 30, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

certbot-dns-route53 - no clear way to handle duplicate zone definitions
2 participants