Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns-route53: deprecate --dns-route53-propagation-seconds #9619

Merged
merged 1 commit into from
Mar 23, 2023
Merged

dns-route53: deprecate --dns-route53-propagation-seconds #9619

merged 1 commit into from
Mar 23, 2023

Conversation

alexzorin
Copy link
Collaborator

Fixes #9121.

bmw
bmw approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@bmw bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't know if you think we should tackle #9618 first.

@bmw bmw added the area: dns label Mar 23, 2023
@alexzorin
Copy link
Collaborator Author

Thanks! I don't think the order matters much, we'll get it in before next release.

@alexzorin alexzorin merged commit 8037321 into master Mar 23, 2023
@alexzorin alexzorin deleted the route53-deprecate-prop-flag branch March 23, 2023 20:28
@alexzorin alexzorin mentioned this pull request Apr 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmw bmw bmw approved these changes

Assignees
No one assigned
Labels
area: dns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--dns-route53-propagation-seconds not respected?
2 participants
@alexzorin @bmw