acme.messages.OrderResource: Make roundtrippable through JSON #9617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if you to_json() an `OrderResource` and later deserialize it, the `AuthorizationResource` objects don't come back through the round-trip (they just get de-jsonified as frozendicts and worse, they can't even be passed to `AuthorizationResource.from_json` because frozendicts aren't dicts). In addition, the `csr_pem` field gets encoded as an array of integers, which definitely does not get de-jsonified into what we want. Fix these by adding an encoder to `authorizations` and encoder and decoder to `csr_pem`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you to_json() an
OrderResourceand later deserialize it, theAuthorizationResourceobjects don't come back through the round-trip (they just get de-jsonified as frozendicts and worse, they can't even be passed toAuthorizationResource.from_jsonbecause frozendicts aren't dicts). In addition, thecsr_pemfield gets encoded as an array of integers, which definitely does not get de-jsonified into what we want.Fix these by adding an encoder to
authorizationsand encoder and decoder tocsr_pem.Fixes #9615
Pull Request Checklist
mastersection ofcertbot/CHANGELOG.mdto include a description of the change being made.AUTHORS.mdif you like.