Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve documentation about shell commands in hooks #9612

Merged
merged 1 commit into from
Mar 23, 2023
Merged

improve documentation about shell commands in hooks #9612

merged 1 commit into from
Mar 23, 2023

Conversation

calestyo
Copy link
Contributor

Fixes #9611.

Copy link
Member

@bmw bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can fix the lint error, I'll merge this.

@bmw bmw assigned bmw and calestyo Mar 20, 2023
@calestyo
Copy link
Contributor Author

AFAICS that was just the line length? Wrapped it now before 100 characters (which I guess is your limit?).

@calestyo calestyo requested a review from bmw March 22, 2023 22:39
Fixes #9611.

Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
@calestyo
Copy link
Contributor Author

Forgot to stage the changes before amending the commit 😅

Copy link
Member

@bmw bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens. LGTM! Thanks.

@bmw bmw merged commit 7ce1f17 into certbot:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hook commands wrongly documented to be shell commands
2 participants