Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more verbose docker-compose up for debugging #9605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Erdaza
Copy link

@Erdaza Erdaza commented Mar 5, 2023

Pull Request Checklist

  • The Certbot team has recently expressed interest in reviewing a PR for this. If not, this PR may be closed due our limited resources and need to prioritize how we spend them.
  • If the change being made is to a distributed component, edit the master section of certbot/CHANGELOG.md to include a description of the change being made.
  • Add or update any documentation as needed to support the changes in this PR.
  • Include your name in AUTHORS.md if you like.

@alexzorin
Copy link
Collaborator

I think if we want to improve this, we could call .wait(MAX_SUBPROCESS_WAIT) on the returned process, check that its exit code is 0, and raise an exception if it isn't.

That way, if Popen or docker-compose fail, they should fail fast (instead of after 5 minutes), and the stderr will be printed anyway.

@alexzorin alexzorin added area: testing area: boulder priority: unplanned Work that we believe should be done, but does not have a higher priority. labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: boulder area: testing priority: unplanned Work that we believe should be done, but does not have a higher priority.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants