-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated python setup.py test
call and update packager guide
#8262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Adrien!
The only change I'd like to see is I think we should add a changelog entry about this.
I also wanted to double check that Fedora/EPEL is on board with this change. The message I saw talked about tox (and poetry), but not pytest
. Unless you had a conversation with Felix that I was not a part of, I think we should tag them here just to make sure this will work for them.
To add a note on the relevant PR, @bmw and I received an email yesterday from Felix (Fedora/EPEL integrator) saying he is fine with us using |
Thanks for double checking that and keeping this thread updated! All I think we need now is a changelog entry to help flag this change for packagers. |
Changelog added. |
certbot/CHANGELOG.md
Outdated
@@ -12,6 +12,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/). | |||
### Changed | |||
|
|||
* Support for Python 3.5 has been removed. | |||
* Update the packaging instructions to promote usage of `python -m pytest` to test Certbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I almost got bit by #8272 again!
Can you merge master
into this branch and add this to the 1.9.0 section?
Otherwise, this PR LGTM!
Fixes #7585
This PR removes the specific configuration to configure the test runner included in
setuptools
to use pytest, the deprecated parameters related to setuptools testing insetup.py
, and update the packaging guide to usepython -m pytest
instead ofpython setup.py test
.The farm test
test_sdist.sh
is also updated to use directly pytest. This test is designed to reproduce the steps used by OS integrators when they packagecertbot
, and ensure that we are not breaking something that will impact their work. We discussed with integrators from RHEL/CentOS and Debian, and they are fine with us testing sdist directly with pytest.One execution of the
test_sdist.sh
farm test with the modifications made by this PR can be seen here: https://dev.azure.com/certbot/certbot/_build/results?buildId=2606&view=results