Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP2 Support #7113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add HTTP2 Support #7113

wants to merge 4 commits into from

Conversation

TheBrokenRail
Copy link

Fixes #3646

@LubosKolouch
Copy link

This is now quite old issue - any progress?

@bmw bmw added the priority: unplanned Work that we believe should be done, but does not have a higher priority. label Mar 25, 2020
@emilv emilv mentioned this pull request Oct 8, 2020
Open
@emilv
Copy link

emilv commented Oct 8, 2020

What needs to happen with this PR to get it reviewed?

@Wirone
Copy link

Wirone commented Oct 14, 2020

@bmw You added priority: significant label to #3646 few days ago but this PR is more than one year old... Maybe it can be merged and issue can be closed? 🤔

@bmw
Copy link
Member

bmw commented Oct 19, 2020

This PR is a start, but as far as I can tell, the code added here is unreachable without further modifications to Certbot.

To flag a few other high level things quickly:

  • Flags like --http2 need to be added. This code references them but doesn't actually add them to Certbot's CLI.
  • The interactive UI code added here is unused and should be deleted for now. I think the initial version of this should default to HTTP2 not being enabled and you can only enable it through CLI flags. We change things in the future to push it to more users if it seems to be working well.
  • Due to how Certbot's plugin system works, enabling HTTP2 should probably be done through a proper call to enhance with the value and flags the plugin should expect properly documented.
  • Tests need to be added

If someone wants to do this work, we'll take a look when we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority: unplanned Work that we believe should be done, but does not have a higher priority.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP2 support in Nginx plugin
5 participants
@TheBrokenRail @LubosKolouch @emilv @Wirone @bmw