Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated uses of OpenSSL.crypto.X509Extension #9828

Open
adferrand opened this issue Oct 30, 2023 · 2 comments · Fixed by #9848 · May be fixed by #9909
Open

Remove deprecated uses of OpenSSL.crypto.X509Extension #9828

adferrand opened this issue Oct 30, 2023 · 2 comments · Fixed by #9848 · May be fixed by #9909
Assignees
@wgreenberg
Labels
area: code health area: pyca priority: significant Issues with higher than average priority that do not need to be in the current milestone.
Milestone
2.11.0

Comments

@adferrand
Copy link
Collaborator

pyopenssl >= 23.3.0 deprecates usage of OpenSSL.crypto.X509Extension in favor of its implementation in cryptography.

We need to adapt significantly the crypto module accordingly, and potentially adapt the minimal versions of cryptography and pyopenssl to ensure the migration path is valid.
@bmw bmw added this to the 2.8.0 milestone Nov 14, 2023
@bmw bmw added the priority: significant Issues with higher than average priority that do not need to be in the current milestone. label Nov 14, 2023
@bmw
Copy link
Member

bmw commented Nov 14, 2023

I think we should either fix this soon or talk with cryptography devs about when they plan to remove this feature.

@bmw bmw added the area: pyca label Nov 14, 2023
@bmw bmw mentioned this issue Dec 3, 2023
Merged
@bmw bmw closed this as completed in #9848 Dec 5, 2023
@bmw bmw reopened this Jan 4, 2024
@bmw bmw modified the milestones: 2.8.0, 2.9.0 Jan 4, 2024
@bmw
Copy link
Member

bmw commented Jan 4, 2024

We still need to do something here to actually deal with the deprecation and not just silence the warning. I just did the latter in #9848.

@markdboyd markdboyd mentioned this issue Feb 7, 2024
Merged
@zoracon zoracon modified the milestones: 2.9.0, 2.10.0 Feb 27, 2024
@wgreenberg wgreenberg linked a pull request Mar 5, 2024 that will close this issue
Open
@zoracon zoracon modified the milestones: 2.10.0, 2.11.0 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wgreenberg wgreenberg

Labels
area: code health area: pyca priority: significant Issues with higher than average priority that do not need to be in the current milestone.
Projects
None yet
Milestone
2.11.0
4 participants
@wgreenberg @zoracon @bmw @adferrand