Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code 6976 #7005

Closed
wants to merge 2 commits into from
Closed

Fix code 6976 #7005

wants to merge 2 commits into from

Conversation

Nanmozhi22
Copy link

Pull Request Motivation

Kind

Release Note

NONE

KarthikAppala and others added 2 commits May 10, 2024 18:27
@KarthikAppala @sankalp-at-gh
@brianwarner @annanmozhi
Design Doc for referencing cabundle using kubernetes native objects(s…
8014228 
…ecrets/configmaps)

Issue reference cert-manager#5514

Authored-by: Karthik Appala <karthik.appala@fmr.com>
Signed-off-by: Karthik Appala <karthik.appala@fmr.com>
Co-Authored-By: Sankalp Yengaldas <sankalp.yb@fmr.com>
Signed-off-by: Sankalp Yengaldas <sankalp.yb@fmr.com>
Co-Authored-By: Brian Warner <brian.warner2@fmr.com>
Signed-off-by: Brian Warner <brian.warner2@fmr.com>
Signed-off-by: An, Nanmozhi <Nanmozhi.An@fmr.com>
@annanmozhi
regular expression
c160fc8 
Signed-off-by: An, Nanmozhi <Nanmozhi.An@fmr.com>
@cert-manager-prow cert-manager-prow bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels May 12, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wallrj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the kind/design Categorizes issue or PR as related to design. label May 12, 2024
@cert-manager-prow
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2024
@cert-manager-prow
Copy link
Contributor

Hi @Nanmozhi22. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 12, 2024
@Nanmozhi22
Copy link
Author

/assign @username

@cert-manager-prow
Copy link
Contributor

@Nanmozhi22: GitHub didn't allow me to assign the following users: username.

Note that only cert-manager members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @username

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Nanmozhi22
Copy link
Author

This issue has been addressed in different repo, as per the issue #7019 , hence closing this PR

The issue has been fixed there in cert-manager/cmctl#66

@Nanmozhi22 Nanmozhi22 closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/design Categorizes issue or PR as related to design. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nanmozhi22 @KarthikAppala @annanmozhi