Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip gateway TLS listener in passthrough mode #6986

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vehagn
Copy link

@vehagn vehagn commented May 4, 2024

Pull Request Motivation

I've tried to fix #6985 combining HTTPS listeners with TLS-termination and TLS listeners with TLS-passthrough that I reported earlier.

I'm unsure if this change will introduce unwanted behaviour, though all the tests are passing.

Kind

bug

Release Note

Skip Gateway TLS-listeners in passthrough mode

@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 4, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 4, 2024
@cert-manager-prow
Copy link
Contributor

Hi @vehagn. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cert-manager-prow cert-manager-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 4, 2024
vehagn added 2 commits May 4, 2024 12:53
Signed-off-by: Vegard Hagen <vegard@stonegarden.dev>
Signed-off-by: Vegard Hagen <vegard@stonegarden.dev>
@vehagn vehagn force-pushed the fix/skip-gateway-tls-listener-in-passthrough-mode branch from 2fd3883 to 90910d4 Compare May 4, 2024 10:53
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway: Combining HTTPS listener with TLS-termination and TLS listener with TLS-passthrough
1 participant