Added class in ingressClassName as default if not specified #6908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alert IngressWithoutClassName was introduced to Cluster. whether Ingress objects would exist without an ingressClassName specified. Given that without an ingressClassName specified, it's not clear what the ingress object is supposed to do, it's vital that alerting is taking place and actions are taken to set the ingressClassName properly for each ingress object.
And as the Ingress resources without a spec.ingressClassName are generated by the Cert-Manager.
Pull Request Motivation
We can create an Ingress without having IngressClassName specified. I am getting alerts messages that ingress Exists without IngressClassName Specified.
I propose that we can add default ingressClassName to issuer if ingressClassName is not specified.
Expected behaviour:
It should Set default ingressClassName if className is not specified.
Kind
bug : #6897
Release Note