Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Remove extra space/line from cert-manager release manifest #6849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kashifest
Copy link

@kashifest kashifest commented Mar 12, 2024

Pull Request Motivation

cert-manager.yaml manifest in recent releases have an extra line/ trailing whitespaces which is being objected by some linters. This is originated in webhook-deployment manifest. This PR sends a small fix for that.

Kind

bug

Release Note

Fix trailing space issue in cert-manager.yaml release manifest

Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@jetstack-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2024
@jetstack-bot
Copy link
Contributor

Hi @kashifest. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the area/deploy Indicates a PR modifies deployment configuration label Mar 12, 2024
@inteon
Copy link
Member

inteon commented Mar 12, 2024

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2024
@inteon
Copy link
Member

inteon commented Mar 12, 2024

Do you have an example of such a linter @kashifest?
Maybe we can add this linter to our CI pipeline.

@kashifest
Copy link
Author

Do you have an example of such a linter @kashifest? Maybe we can add this linter to our CI pipeline.

Actually, this was some in-house linter that we use downstream, however if you have "files.trimTrailingWhitespace": true in you Vscode for example, vscode reports it.

@inteon
Copy link
Member

inteon commented Apr 23, 2024

/test pull-cert-manager-master-make-verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants