-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/daemon: add entrypoint for ceph-volume to mount OSDs only #1605
Conversation
a217c71
to
b9a4661
Compare
…ayalive. Signed-off-by: utp887 <R.Martinez@redhat.com>
b9a4661
to
c9947b1
Compare
@dsavineau this is what I had in mind for a 'maintenance' entrypoint, where we would be able to run ceph-objectstore-tool/ceph-bluestore-tool. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to duplicate the whole osd_volume_activate.sh code just for removing the ceph-osd start line.
So we should do the same than osd_disk_activate with a start parameter.
Also I don't think we should set the STAYALIVE
variable in the entrypoint but let the user set -e DEBUG=stayalive
instead with the container CLI.
Would a change like this make more sense? If so I can push another PR.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required. |
Adds: "-e CEPH_DAEMON=OSD_CEPH_VOLUME_ACTIVATE_ONLY" .
After osd.id lvm is (unlocked)+mounted, the entrypoint calls stayalive
in order to stay running without starting ceph-osd service. This
entrypoint enables maintenance of OSDs in containerized_deployment.
Closes: BZ - 1811910
Signed-off-by: utp887 R.Martinez@redhat.com