ceph_osd_flag: support setting noout flag at osd or bucket level #6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
force-pushed
the
refact_module_osd_flag
branch
from
3cbddd0
to
ca25be8
Compare
guits
changed the title
guits
force-pushed
the
refact_module_osd_flag
branch
2 times, most recently
from
0a2d372
to
4699443
Compare
guits
force-pushed
the
refact_module_osd_flag
branch
2 times, most recently
from
9b4c47a
to
a6a1468
Compare
|
jenkins test centos-non_container-update |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
guits
changed the title
guits
force-pushed
the
refact_module_osd_flag
branch
from
a6a1468
to
38e9706
Compare
guits
changed the title
|
jenkins test centos-non_container-update |
guits
changed the title
guits
force-pushed
the
refact_module_osd_flag
branch
from
38e9706
to
edd836b
Compare
guits
changed the title
|
jenkins test centos-non_container-update |
guits
changed the title
Currently `ceph_osd_flag` module only supports setting `noout` flag at the cluster level. Ceph supports setting this flag at the osd or the bucket level so let's implement this support in `ceph_osd_flag` module. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
reporting missing line numbers might help and won't hurt the opposite case. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
It is safer to set the `noout` flag at the bucket level instead of the whole cluster. This commit updates the 3 playbooks where we set `noout` flag so it doesn't set it at the whole cluster level anymore. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
force-pushed
the
refact_module_osd_flag
branch
from
edd836b
to
66741ff
Compare
guits
changed the title
|
jenkins test centos-non_container-update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ceph_osd_flagmodule only supports settingnooutflag atthe cluster level.
Ceph supports setting this flag at the osd or the bucket level so let's
implement this support in
ceph_osd_flagmodule.Signed-off-by: Guillaume Abrioux gabrioux@redhat.com