Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internally handle rate-limit #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Xiphe
Copy link

@Xiphe Xiphe commented Jan 15, 2024

fix #15

@Xiphe
Copy link
Author

Xiphe commented Jan 15, 2024

pre-published as @xiphe/mailjs@3.1.0-preview.1

@cemalgnlts
Copy link
Owner

This is a great feature. But we won't need the second commit (add rate-limit even), SSE (events) works differently and we will not have a problem with rate-limit.

@Xiphe
Copy link
Author

Xiphe commented Jan 16, 2024

Hi @cemalgnlts, thanks for the feedback, glad you like it!

Ok, that's cool with me. I added that feature to debug why the lib doesn't work in CI (seems as if I'm not the only one trying to use that service from github actions and therefore run in a LOT of rate-limiting).

Will remove that commit and the custom backend support into a separate pr later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle rate-limit errors internally
2 participants