fix!: update the implementation to correctly reflect the Verify and Validate roles for ShareProof and RowProof
#1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `Validate` roles for `ShareProof` and `RowProof`
rach-id
requested review from
rootulp and
cmwaters
and removed request for
a team
rootulp
previously approved these changes
May 13, 2024
rootulp
reviewed
May 13, 2024
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
…oof-methods # Conflicts: # types/share_proof_test.go
rootulp
approved these changes
May 13, 2024
cmwaters
approved these changes
Jun 4, 2024
Comment on lines
26
to
27
| // HACKHACK performing subtraction with unsigned integers is unsafe. | ||
| if int(rp.EndRow-rp.StartRow+1) != len(rp.RowRoots) { |
There was a problem hiding this comment.
Do we check this? i.e. rp.EndRow > rp.StartRow. If not, do we want to check this?
There was a problem hiding this comment.
I don't think we do. Will open a subsequent PR. thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1356