Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more information if ShareProof and RowProof verification failed #1359

Open
rach-id opened this issue May 13, 2024 · 0 comments
Open

Comments

@rach-id
Copy link
Member

rach-id commented May 13, 2024

          [separate issue] since `VerifyProof` only returns a bool value, I expect callers will be need debugging tools if they receive a `false` here.

We could consider modifying the API so that an error is returned if VerifyProof returns false.

// VerifyProof returns true if ...
// VerifyProof returns false and an error if ...
func (sp ShareProof) VerifyProof(root []byte) (bool, error) {

Originally posted by @rootulp in #1357 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant