Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(structure): restructure project layout #1712

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stegayet
Copy link
Contributor

@stegayet stegayet commented May 11, 2023

Towards #1705.

This PR restructures project layout as expected by poetry. Needed changes are:

  • changing from t/ to tests/ to follow standard convention.
  • getting rid of extras folder as it seems unused (Appveyor CI related script but this repository is using GHA + symlink to requirements folder) and setuptools is having trouble finding top-level package, i.e kombu. (EDIT: done in 02509ac)

With this change, we can safely remove packages argument to setup call.

Resources:

How this has been tested ?

  • python setup.py build has been successfully run with correct package content.

@stegayet stegayet force-pushed the chore/restructure-project-layout branch 2 times, most recently from 58f5117 to 150df7a Compare May 11, 2023 23:39
@Nusnus Nusnus self-requested a review May 13, 2023 20:13
@stegayet stegayet force-pushed the chore/restructure-project-layout branch 4 times, most recently from 792d711 to 80600af Compare May 15, 2023 09:41
@stegayet stegayet marked this pull request as ready for review May 15, 2023 13:27
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why #1723 don't work stand alone? can you share more detail please

@stegayet
Copy link
Contributor Author

As per your CI run, it says:

  3.9-linux-unit: FAIL code error: Multiple top-level packages discovered in a flat-layout: ['t', 'kombu'].

First commit in this PR switches from t to tests and fixes this issue IMO 😄

@stegayet stegayet force-pushed the chore/restructure-project-layout branch from 80600af to 50fec65 Compare May 16, 2023 14:30
@stegayet stegayet requested a review from auvipy May 16, 2023 14:33
@stegayet stegayet force-pushed the chore/restructure-project-layout branch from ce1ed56 to 6307b96 Compare May 16, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants