fix: don't crash on properties.body_encoding: utf-8
#1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankgeorg
changed the title
properties.body_encoding: utf-8
auvipy
requested changes
Apr 8, 2023
|
Yes I would love to! can you help be a bit figuring out where the related tests are? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a message has an
properties.body_encodingofutf-8(e.g. the default on https://github.com/node-celery-ts/node-celery-ts), celery workers crash with an errorAttributeError: 'NoneType' object has no attribute 'decode'.utf-8is functionally equivalent to not providing an encoding, so this should be good.